Improve performance of memoized methods with arguments by ~50% #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running benchmark.rb prior to change:
```
Warming up --------------------------------------
test_no_args 526.602k i/100ms
Calculating -------------------------------------
test_no_args 5.172M (± 1.8%) i/s - 26.330M in 5.092880s
Calculating -------------------------------------
test_no_args 4.000k memsize ( 0.000 retained)
100.000 objects ( 0.000 retained)
0.000 strings ( 0.000 retained)
Warming up --------------------------------------
test_with_args 221.217k i/100ms
Calculating -------------------------------------
test_with_args 2.203M (± 5.6%) i/s - 11.061M in 5.045789s
Calculating -------------------------------------
test_with_args 12.000k memsize ( 0.000 retained)
300.000 objects ( 0.000 retained)
0.000 strings ( 0.000 retained)
```
After:
```
Warming up --------------------------------------
test_no_args 529.096k i/100ms
Calculating -------------------------------------
test_no_args 5.247M (± 1.3%) i/s - 26.455M in 5.042306s
Calculating -------------------------------------
test_no_args 4.000k memsize ( 0.000 retained)
100.000 objects ( 0.000 retained)
0.000 strings ( 0.000 retained)
Warming up --------------------------------------
test_with_args 331.604k i/100ms
Calculating -------------------------------------
test_with_args 3.471M (± 0.8%) i/s - 17.575M in 5.064376s
Calculating -------------------------------------
test_with_args 12.000k memsize ( 0.000 retained)
300.000 objects ( 0.000 retained)
0.000 strings ( 0.000 retained)
```
CKolkey
changed the title
CKolkey
changed the title
|
This looks good, thanks for the patch! |
AlexWayfer
added a commit
to AlexWayfer/alt_memery
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the information in this twitter thread, I believe we can improve the hash-lookup times of memoized method calls with arguments substantially, with only a small change.
https://threadreaderapp.com/thread/1831412716533379235.html
Running benchmark.rb prior to change:
And after:
The
test_no_argscase is unaffected (as expected) but thetest_with_argscase sees a very significant speedup.